On Sun, Apr 20, 2014 at 4:54 AM, Borislav Petkov <bp@xxxxxxx> wrote: > On Fri, Apr 18, 2014 at 08:53:46PM -0600, Myron Stowe wrote: >> With the amd_bus.c updates to support additional AMD processors (11h, 12h, >> 14h 15h and 16h) 'quirk_amd_nb_node' seems to be redundant. This patch >> removes it. >> >> Signed-off-by: Myron Stowe <myron.stowe@xxxxxxxxxx> > > Good idea. Has this been tested, though? There are a bunch of places > using dev_to_node() which this quirk corrects, especially 'local_cpus' > in a bunch of sysfs nodes in the PCI hierarchy /sys/devices/pci*. My testing was related to the PCI hierarchy /sys/devices/pci* as this was the root issue I'm trying to get resolved. Daniel also responded - Thanks Dan! - indicating that the changes are ok related to his concerns. > > We want to make sure this doesn't break that and other dev_to_node() > callsites. Agreed, which is at least in part why this is a separate patch. I'm going to run some more testing and then post with most of your comments incorporated. Thanks again for the review. Myron > > Thanks. > > -- > Regards/Gruss, > Boris. > > Sent from a fat crate under my desk. Formatting is fine. > -- > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html