> -----Original Message----- > From: Bjorn Helgaas [mailto:bhelgaas@xxxxxxxxxx] > Sent: Thursday, April 24, 2014 2:31 PM > To: Rajat Jain > Cc: linux-pci@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Rajat > Jain; Guenter Roeck > Subject: Re: [PATCH] pci/pciehp: Allow polling/irq mode to be decided > on a per-port basis > > On Mon, Mar 31, 2014 at 04:51:53PM -0700, Rajat Jain wrote: > > Today, there is a global pciehp_poll_mode module parameter using > which > > either _all_ the hot-pluggable ports are to use polling, or _all_ the > > ports are to use interrupts. > > > > In a system where a certain port has IRQ issues, today the only > option > > is to use the parameter that converts ALL the ports to use polling > mode. > > This is not good, and hence this patch intruduces a bit field that > can > > be set using a PCI quirk that indicates that polling should always be > > used for this particular PCIe port. The remaining ports can still > > hoose to continue to operate in whatever mode they wish to. > > > > Signed-off-by: Rajat Jain <rajatxjain@xxxxxxxxx> > > Signed-off-by: Rajat Jain <rajatjain@xxxxxxxxxxx> > > Signed-off-by: Guenter Roeck <groeck@xxxxxxxxxxx> > > I'm willing to merge this, but I'd prefer to merge it along with a > quirk that actually sets dev->hotplug_polling. Otherwise it's dead > code and I'll have no way to tell whether we need to keep it. > Bjorn, what would be the proper location for such a quirk ? We use it to help simulating hotplug support on an IDT PES12NT3. The code is a bit more invasive than just the quirk itself, since it also needs to touch link and slot status registers, so quirks.c doesn't seem appropriate. drivers/pci/pes12nt3.c, maybe, with a separate configuration option ? Or in the hotplug directory ? Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
