On Fri, Apr 25, 2014 at 08:48:14AM +0000, Shahed Shaikh wrote:
> > diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> > b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> > index dbf7539..26f022b 100644
> > --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> > +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> > @@ -690,8 +690,8 @@ int qlcnic_setup_tss_rss_intr(struct qlcnic_adapter
> > *adapter)
> > adapter->msix_entries[vector].entry = vector;
> >
> > restore:
> > - err = pci_enable_msix(pdev, adapter->msix_entries, num_msix);
> > - if (err > 0) {
> > + err = pci_enable_msix_exact(pdev, adapter->msix_entries,
> > num_msix);
> > + if (err == -ENOSPC) {
> > if (!adapter->drv_tss_rings && !adapter->drv_rss_rings)
> > return -ENOSPC;
>
> I think, it would be good if we return "err" instead of "-ENOSPC" .
>
> if (!adapter->drv_tss_rings && !adapter->drv_rss_rings)
> - return -ENOSPC;
> + return err;
At this point "err" could only be -ENOSPC. I am not sure why returning
"err" is better, but I'll repost if you insist.
>
> Thanks,
> Shahed
>
--
Regards,
Alexander Gordeev
agordeev@xxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
