Re: Coverity CID 712278: c_can_pci_probe() doesn't check pci_enable_msi() return value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/03/2014 06:53 PM, Bjorn Helgaas wrote:
> Coverity complains that c_can_pci_probe() calls pci_enable_msi()
> without checking the result:
> 
> 
> CID 712278 (#1 of 1): Unchecked return value (CHECKED_RETURN)
> 3. check_return: Calling pci_enable_msi_block without checking return
> value (as is done elsewhere 88 out of 105 times).
>  88        pci_enable_msi(pdev);
> 
> This is CID 712278.

Thanks, I've applied Wolfgang's patch ("can: c_can_pci: enable PCI bus
master only for MSI"), which fixes this problem.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux