Re: [PATCH V1 net] net/mlx4_core: Preserve pci_dev_data after __mlx4_remove_one()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Wei Yang <weiyang@xxxxxxxxxxxxxxxxxx>
Date: Thu, 10 Apr 2014 17:25:24 +0800

> pci_match_id() just match the static pci_device_id, which may return NULL if
> someone binds the driver to a device manually using
> /sys/bus/pci/drivers/.../new_id.
> 
> This patch wrap up a helper function __mlx4_remove_one() which does the tear
> down function but preserve the drv_data. Functions like
> mlx4_pci_err_detected() and mlx4_restart_one() will call this one with out
> releasing drvdata.
> 
> Fixes: 97a5221 "net/mlx4_core: pass pci_device_id.driver_data to __mlx4_init_one during reset".
> 
> CC: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> CC: Amir Vadai <amirv@xxxxxxxxxxxx>
> CC: Jack Morgenstein <jackm@xxxxxxxxxxxxxxxxxx>
> CC: Or Gerlitz <ogerlitz@xxxxxxxxxxxx>
> Signed-off-by: Wei Yang <weiyang@xxxxxxxxxxxxxxxxxx>
> 
> ---
> V0 --> V1:
>    1. zero the mlx4_priv at the end of __mlx4_remove_one
>    2. add a flag in mlx4_priv to mark it is released or not

This doesn't apply to the current 'net' tree, please respin.

And Jack, please do not place any leading spaces before your "Acked-by:",
patchwork will not parse it correctly and pick it up automatically for
me if you do that.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux