On Fri, Mar 14, 2014 at 05:38:46PM +0800, Yijing Wang wrote: > Refactor pci_is_bridge(), check pci device > hdr_type instead, and move it in include/linux/pci.h > > Signed-off-by: Yijing Wang <wangyijing@xxxxxxxxxx> > --- > include/linux/pci.h | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/include/linux/pci.h b/include/linux/pci.h > index 33aa2ca..22370c4 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -1649,6 +1649,12 @@ static inline bool pci_is_pcie(struct pci_dev *dev) > return pci_pcie_cap(dev); > } > > +static inline bool pci_is_bridge(struct pci_dev *dev) > +{ > + return dev->hdr_type == PCI_HEADER_TYPE_BRIDGE || > + dev->hdr_type == PCI_HEADER_TYPE_CARDBUS; > +} There's no point in adding this unless somebody uses it (but I assume you probably meant to use it in acpi_pci_find_companion() as I mentioned). > /** > * pcie_caps_reg - get the PCIe Capabilities Register > * @dev: PCI device > -- > 1.7.1 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html