----- Original Message ----- > From: "Yinghai Lu" <yinghai@xxxxxxxxxx> > To: "Bjorn Helgaas" <bhelgaas@xxxxxxxxxx> > Cc: "Dave Airlie" <airlied@xxxxxxxxxx>, linux-pci@xxxxxxxxxxxxxxx > Sent: Friday, 4 April, 2014 10:06:32 AM > Subject: Re: Coverity CID 142811: pci_set_vga_state() operands don't affect result > > On Thu, Apr 3, 2014 at 1:43 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: > > Coverity complains about this in drivers/pci/pci.c: > > > > CID 142811 (#1 of 1): Operands don't affect result > > (CONSTANT_EXPRESSION_RESULT) > > result_independent_of_operands: flags & (2U /* 1 << 1 */) & > > (command_bits & 4294967292U /* ~(1 | 2) */) is always 0 regardless of > > the values of its operands. This occurs as the logical operand of if. > > > > 4128 WARN_ON((flags & PCI_VGA_STATE_CHANGE_DECODES) & > > (command_bits & ~(PCI_COMMAND_IO|PCI_COMMAND_MEMORY))); > > > > This is a result of 3448a19da479 "vgaarb: use bridges to control VGA > > routing where possible." > > > > I wonder if that middle "&" was intended to be "&&"? > > must be. otherwise always get 0. Yeah I'd agree :-) Dave. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
