Coverity CIDs 1011624, 1011625: mei/pci-me.c doesn't check pci_enable_msi() return value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Coverity complains that mei_me_probe() and mei_me_pci_resume() call
pci_enable_msi() without checking the result.  They do check
indirectly, by testing pci_dev_msi_enabled(), but it would be nicer to
check the pci_enable_msi() result directly:

CID 1011625 (#1 of 1): Unchecked return value (CHECKED_RETURN)
9. check_return: Calling pci_enable_msi_block without checking return
value (as is done elsewhere 88 out of 105 times).
173        pci_enable_msi(pdev);
174
175         /* request and enable interrupt */
176        if (pci_dev_msi_enabled(pdev))

These are CIDs 1011624 and 1011625.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux