Hello Jingoo, > -----Original Message----- > From: Jingoo Han [mailto:jg1.han@xxxxxxxxxxx] > Sent: Tuesday, April 01, 2014 4:00 PM > To: 'Bjorn Helgaas' > Cc: linux-pci@xxxxxxxxxxxxxxx; Mohit KUMAR DCG; Pratyush ANAND; 'Marek > Vasut'; 'Richard Zhu'; 'Kishon Vijay Abraham I'; 'Jingoo Han' > Subject: [PATCH] PCI: designware: Remove unnecessary RC BAR setting > > According to the spec, the synopsys core does not implement the optional > BARs such as BAR0/1. This is based on the assumption that the RC host > probably has registers on some other internal bus and has knowledge and > setup access to these registers already. > So, remove unnecessary RC BAR setting. > - Normally BARs in RC are not used but somehow available in the design. One possible BAR use can be if RC has some memory connected to the BAR that needs to be accessed through link. Otherwise we can ignore BARs setup here. Thanks Mohit > Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx> > --- > Tested on Exynos5440. > > drivers/pci/host/pcie-designware.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie- > designware.c > index 6d23d8c..7bee01f 100644 > --- a/drivers/pci/host/pcie-designware.c > +++ b/drivers/pci/host/pcie-designware.c > @@ -798,10 +798,6 @@ void dw_pcie_setup_rc(struct pcie_port *pp) > } > dw_pcie_writel_rc(pp, val, PCIE_LINK_WIDTH_SPEED_CONTROL); > > - /* setup RC BARs */ > - dw_pcie_writel_rc(pp, 0x00000004, PCI_BASE_ADDRESS_0); > - dw_pcie_writel_rc(pp, 0x00000000, PCI_BASE_ADDRESS_1); > - > /* setup interrupt pins */ > dw_pcie_readl_rc(pp, PCI_INTERRUPT_LINE, &val); > val &= 0xffff00ff; > -- > 1.7.10.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
