Re: how to trigger pcieport runtime suspend?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 24 Mar 2014, Bjorn Helgaas wrote:

> [+cc Rafael, Pavel, linux-pm]
> 
> On Sun, Mar 23, 2014 at 12:16 PM, Andreas Noever
> <andreas.noever@xxxxxxxxx> wrote:
> > The pcieport driver defines runtime_suspend and runtime_resume methods
> > (pcie_port_runtime_suspend/resume in portdrv_pci.c). I am trying to
> > trigger that code. But I cannot get power/runtime_usage to drop to
> > zero.
> >
> > Initially power/runtime_usage is set to 2. The 2 comes (imho) from:
> > pci_pm_init -> pm_runtime_forbid
> > local_pci_probe -> pm_runtime_get_sync
> >
> > The pm_runtime_forbid can be undone with echo auto > power/control,
> > but the second one seems to never go away. local_pci_probe spots the
> > following comment:
> > "If the driver supports runtime PM, it should call
> > pm_runtime_put_noidle() in its probe routine and
> > pm_runtime_get_noresume() in its remove routine." I cannot find any
> > such calls in the pcieport driver (or in the port service drivers).
> >
> > What am I missing?

You're not missing anything, but apparently the people who added
runtime PM support to the pcieport driver missed the comment you 
quoted.

If you add those calls to the driver, does it do what you want?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux