On Fri, Mar 21, 2014 at 4:07 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Friday 21 March 2014 13:59:35 Phil.Edworthy@xxxxxxxxxxx wrote:
>> > From: Arnd Bergmann <arnd@xxxxxxxx>
>> > static const struct of_device_id rcar_pcie_of_match[] = {
>> > { .compatible = "renesas,r8a7779-pcie", .data =
>> rcar_pcie_phy_init_rcar_h1},
>> > { .compatible = "renesas,r8a7790-pcie", .data = rcar_pcie_hw_init},
>> > { .compatible = "renesas,r8a7791-pcie", .data = rcar_pcie_hw_init},
>> > {},
>> > };
>> >
>> > If you need other differences in the future, you can extend this
>> > to use a pointer to a struct containing the init function pointer.
>>
>> Ok, I understand what you mean, though the rcar_pcie_phy_init_rcar_h1
>> function is an extra call for r8a7779 devices to setup the PHY, not an
>> alternative to rcar_pcie_hw_init.
>
> I assumed that would be trivial to change, by calling rcar_pcie_hw_init
> at the end of rcar_pcie_phy_init_rcar_h1 rather than the other way round.
And this would allow to propagate the error code from
rcar_pcie_phy_init_rcar_h1(), as currently rcar_pcie_hw_init() ignores it,
and returns void.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
