Re: [PATCH] pciehp: only wait command complete for really hotplug control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 25, 2014 at 9:45 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
> On Mon, Feb 24, 2014 at 6:55 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>
> It's quite likely that I'm mistaken, and this is not a silicon
> problem, especially since two vendors apparently did it the same way.
> But I'd like to see the explanation from Intel about how this complies
> with the spec.  I provided a spec reference for why I think we should
> wait for a command completed event.  The next step would be for you or
> Intel to respond with "here's the section in the spec that you missed,
> and it says the OS should not wait for an event unless it is changing
> the EIC, PCC, PIC, or AIC bits."

Hi, Bjorn,

Intel admits that it is silicon problem.
CC will be set iff EIC || PCC || PIC || AIC is set.

so please me know if you want
1. just use the patch in current form. it will do that for ...
2. or modify the patch to check vendor to set flag for every controller, and use
that to decide if need to wait CC.

BTW, other OS does not check CC for other than the four bits.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux