Re: [PATCH v2 00/23] scsi: Use pci_enable_msix_range() instead of pci_enable_msix()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2014-03-12 at 22:04 -0600, Bjorn Helgaas wrote:
> On Mon, Feb 24, 2014 at 09:02:00AM +0100, Alexander Gordeev wrote:
> > Hello!
> > 
> > This series is against James Bottomley's SCSI tree [1], but it needs
> > commit f7fc32c ("PCI/MSI: Add pci_enable_msi_exact() and
> > pci_enable_msix_exact()") from from Bjorn Helgaas's PCI tree [2]:
> > 
> > 1. git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
> > 2. git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/msi
> > 
> > Recently pci_enable_msix_exact() function has been accepted to
> > the mainline. That is a variation of pci_enable_msix_range() which
> > allows a device driver to request a particular number of MSI-Xs.
> > 
> > As result, most of the changes posted in version 1 of this series
> > are invalidated and need to use pci_enable_msix_exact() instead of
> > originally posted pci_enable_msix_range() usages.
> > 
> > I removed almost all ACKs, since unlike pci_enable_msix_range()
> > function which returns the number of MSI-Xs allocated or negative
> > errno, pci_enable_msix_exact() returns either zero success code or
> > a negative errno. Although this change is simple, it still entails
> > an updated error code analysis and would be better reviewed by
> > driver maintainers.
> 
> Hi James,
> 
> I think Alexander sent these to linux-scsi hoping that you would handle
> them, but I know it's a hassle because they depend on f7fc32c, which went
> in after the merge window.
> 
> I'd be glad to review these and apply them through my tree, unless you want
> to do it.  I'd like to get these merged in the v3.15 merge window so
> Alexander can move on to something else.  I haven't checked for merge
> conflicts with scsi.git yet, but I assume they'd be pretty trivial if there
> are any.

Sure, any that haven't been applied ... I think we already have some
updates for drivers which do MSIX changes, but for those you'll see the
conflict with scsi.git and you can just drop the patch for that driver.

James

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux