Hi Magnus, On 27/02/2014 09:59, Magnus Damm wrote: > On Thu, Feb 27, 2014 at 3:11 AM, Phil Edworthy > <phil.edworthy@xxxxxxxxxxx> wrote: > > This PCIe Host driver currently does not support MSI, so cards > > fall back to INTx interrupts. > > > > Signed-off-by: Phil Edworthy <phil.edworthy@xxxxxxxxxxx> > > --- > > v2: > > - Use msleep instead of udelay when waiting for the link > > - Use pm_runtime > > - Removed unused definition > > - Also replaced call to devm_request_and_ioremap with devm_ioremap_resource > > and fixed a bug with this when reporting errors. > > > > drivers/pci/host/Kconfig | 6 + > > drivers/pci/host/Makefile | 1 + > > drivers/pci/host/pcie-rcar.c | 588 ++++++++++++++++++++++++++++++++++++++++++ > > drivers/pci/host/pcie-rcar.h | 82 ++++++ > > 4 files changed, 677 insertions(+) > > create mode 100644 drivers/pci/host/pcie-rcar.c > > create mode 100644 drivers/pci/host/pcie-rcar.h > > > > diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig > > index 47d46c6..b1c1787 100644 > > --- a/drivers/pci/host/Kconfig > > +++ b/drivers/pci/host/Kconfig > > @@ -33,4 +33,10 @@ config PCI_RCAR_GEN2 > > There are 3 internal PCI controllers available with a single > > built-in EHCI/OHCI host controller present on each one. > > > > +config PCI_RCAR_GEN2_PCIE > > + bool "Renesas R-Car PCIe controller" > > + depends on ARM && (ARCH_R8A7790 || ARCH_R8A7791 || COMPILE_TEST) > > Hi Phil, > > Thanks for the patch! Just a minor comment from my side at this point: > > Please adjust the Kconfig dependencies into excluding SoC strings to > follow same style as our other drivers. > > - depends on ARM && (ARCH_R8A7790 || ARCH_R8A7791 || COMPILE_TEST) > + depends on ARCH_SHMOBILE || (ARM && COMPILE_TEST) Ok, will do! Thanks Phil -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
