On Tue, Feb 25, 2014 at 11:27 AM, Rajat Jain <rajatxjain@xxxxxxxxx> wrote: > On Mon, Feb 24, 2014 at 4:46 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: >> [+cc Rajat] >> >> On Mon, Feb 24, 2014 at 4:59 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote: >>> On system with 16 PCI express hotplug slots, customer complain every slot >>> will report "Command not completed in 1000 msec" during initialization. >>> >>> Intel says that we should only wait command complete only for >>> Electromechanical Interlock Control >>> Power Controller Control >>> Power Indicator Control >>> Attention Indicator Control > > > Hello, > > I have a HW that generates Command Completion notifications, even > though it does not implement any of the EMI, Power Controller, Power > Indicator, Attention indicator. Although I'm not sure whether or not > this behavior is compliant to PCIe spec, just wanted to pitch in to > convey that there are HW which have this behavior: > > PCI bridge: Integrated Device Technology, Inc. Device 807a (rev 02) > (prog-if 00 [Normal decode]) > SltCap: AttnBtn- PwrCtrl- MRL- AttnInd- PwrInd- HotPlug+ Surprise- > Slot #13, PowerLimit 0.000W; Interlock- NoCompl- > SltCtl: Enable: AttnBtn- PwrFlt- MRL- PresDet+ CmdCplt+ HPIrq+ LinkChg+ > Control: AttnInd Unknown, PwrInd Unknown, Power- Interlock- > SltSta: Status: AttnBtn- PowerFlt- MRL- CmdCplt- PresDet+ Interlock- > Changed: MRL- PresDet- LinkState- Looks like different vendors have different understanding of that part. so may need to add vendor quirk checking for waiting..., aka only wait for IDT for all bits, and other vendor will only wait for 4 bits. Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
