Dear Andrew Murray, On Thu, 20 Feb 2014 18:51:32 +0000, Andrew Murray wrote: > I've noticed that the mvebu and designware both use spinlocks to > serialize access to the configuration space (pci_ops.[read|write]). > However the read/write ops are only ever used from the pci core > (access.c, pci.c) where they are already protected with the pci_lock. > > As far as I can tell these extra spinlocks are superfluous, therefore... > > Can they be removed? > Can future host bridge drivers assume that calls to the pci_ops are serialized? Just had a quick look, and indeed all the PCI configuration space access functions in drivers/pci/access.c seem to be taking the pci_lock, making the internal driver lock useless. Patches welcome! :-) Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
