On Fri, Feb 14, 2014 at 12:39 PM, Rajat Jain <rajatxjain@xxxxxxxxx> wrote:
> Hi Bjorn,
>
> On Fri, Feb 14, 2014 at 9:31 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
>> On Fri, Feb 14, 2014 at 12:21 AM, Izumi, Taku <izumi.taku@xxxxxxxxxxxxxx> wrote:
>>>> Hmm... I see that the Slot has a power controller. Which means that the power to the slot shall not be turned on automatically
>>>> (by HW) when the card is plugged in. Also meaning that the link will not come up automatically - so this does not seem
>>>> like the Link state based hotplug kicking in.
>>>>
>>>> What I suspect is this one:
>>>>
>>>> f02d1843d83b "PCI: pciehp: Remove surprise bit checks"
>>>
>>> You are right.
>>> In case of omitting comit-f02d1843, it worked as expected.
>>> Slot power doesn't become ON automatically when PCIe card is inserted.
>>
>> OK, I dropped f02d1843d83b ("PCI: pciehp: Remove surprise bit
>> checks").
>
> I think part of this commit was still good (The part that drops the
> surprise check when a card is yanked out). That is because when a card
> is yanked out, it shouldn't matter whether the surprise bit is set or
> not - its gotta go.
>
> Functionally, that scenario is already covered by my patches (because
> yanking out a card will make the link go down, hence kicking off link
> state based unplug) - thus no functional change. But just thought I'll
> mention since you were already at this cleanup phase. (If you agree, I
> can send a separate clean patch or you can use Takashi's one).
That sounds reasonable. Send me a patch, if you don't mind, so it's
clear what to do here.
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
