On Wed, Feb 12, 2014 at 1:07 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Wednesday 12 February 2014 12:43:13 Jason Gunthorpe wrote: >> On Tue, Feb 11, 2014 at 11:42:52AM +0100, Arnd Bergmann wrote: >> >> >> Still missing release_region.. >> >> Thoughts on upstreamining these bits? > > Upstreaming them would be great. Patches look correct by inspection as well. > >> > Since the mvebu_pcie_setup() function seems very generic at this, >> > we should probably try to factor out that code into a common >> > helper, at least for arm64, but ideally shared with arm32 >> > as well. >> >> Yah, especially since people are not getting it completely right.. >> >> But some of the trouble here is a lack of a generic pci host driver >> structure, eg I have to pull the domain number out of the ARM32 >> specific structure .. > > I'm sure that Bjorn also has some plans of his own, but I think > we should have a generic host driver structure and gradually move > stuff into it from the architecture specific structs. I don't have plans in this area right now, but I would definitely like to migrate things like the domain, NUMA node, etc., into a generic structure. > Now there is a 'struct pci_host_bridge' that is used on some > architectures already but not on ARM. It also contains a list > of resource windows plus offsets, and there is a set of functions > associated with it: > > pci_create_root_bus() > pcibios_root_bridge_prepare() > > etc. > > Maybe all that's needed is to actually start using those on arm32? > > Arnd > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
