On Mon, Feb 10, 2014 at 06:08:03PM -0700, Bjorn Helgaas wrote: > I skimmed these and the scsi patches, and I think you were right in > proposing an MSI-X enable function that takes a single "number of vectors" > argument, in addition to pci_enable_msix_range(), which takes a minimum and > a maximum. Obviously the pci_enable_msix_fixed() or whatever could be a > simple #define wrapper or something. > > Of the fifty-some net and scsi patches, I counted 23 that use the min == > max pattern, and it seems a shame to have to repeat that expression. (un-CCing netdev@xxxxxxxxxxxxxxx) Hi Bjorn, I propose pci_enable_msix_exact(pdev, entries, nvec) rather than pci_enable_msix_fixed(). Do you prefer this one to return 0/-errno or nvec/-errno? Do you want pci_enable_msi_exact() in addition to pci_enable_msix_exact()? Thanks! > Bjorn -- Regards, Alexander Gordeev agordeev@xxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
