Re: [PATCH V5 7/8] pcie: SPEAr13xx: Add designware pcie support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 11 February 2014 12:23:58 Mohit KUMAR DCG wrote:

> > > diff --git a/drivers/pci/host/Makefile b/drivers/pci/host/Makefile
> > > index 13fb333..42a491d 100644
> > > --- a/drivers/pci/host/Makefile
> > > +++ b/drivers/pci/host/Makefile
> > > @@ -4,3 +4,4 @@ obj-$(CONFIG_PCI_IMX6) += pci-imx6.o
> > >  obj-$(CONFIG_PCI_MVEBU) += pci-mvebu.o
> > >  obj-$(CONFIG_PCI_TEGRA) += pci-tegra.o
> > >  obj-$(CONFIG_PCI_RCAR_GEN2) += pci-rcar-gen2.o
> > > +obj-$(CONFIG_PCIE_SPEAR13XX) += pcie-spear13xx.o
> > 
> > I'd use the "pci" naming instead of "pcie" here for consistency.
> > 
> 
> - No, let it be pcie as SPEAr13xx soc has pci controller as well , though  PCI is
> not used on current eval boards.

Hmm, it's still inconsistent, but I can see your argument.
Let's see if someone has a better idea, otherwise keep the
pcie name.

I'd prefer to avoid having to rename drivers in the long run,
but if we start naming some pcie drivers pci and others pcie,
it gets rather confusing.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux