On Tue, Jan 28, 2014 at 6:47 PM, Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx> wrote: > Add option to enable interrupts to report any errors from > the AHB-PCI bridge to help find any issues with the bridge > when in use. > > Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx> > --- > Cc: Valentine Barshak <valentine.barshak@xxxxxxxxxxxxxxxxxx> > Cc: Simon Horman <horms@xxxxxxxxxxxx> > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > Cc: linux-pci@xxxxxxxxxxxxxxx > Cc: linux-sh@xxxxxxxxxxxxxxx > --- > drivers/pci/host/Kconfig | 9 ++++++ > drivers/pci/host/pci-rcar-gen2.c | 60 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 69 insertions(+) > > diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig > index 47d46c6..6d4c46e 100644 > --- a/drivers/pci/host/Kconfig > +++ b/drivers/pci/host/Kconfig > @@ -33,4 +33,13 @@ config PCI_RCAR_GEN2 > There are 3 internal PCI controllers available with a single > built-in EHCI/OHCI host controller present on each one. > > +config PCI_RCAR_GEN2_ERRIRQ > + bool "Enable error reporting interrupt support" > + depends on PCI_RCAR_GEN2 > + help > + Say Y here to enable support for the bus-error interrupts from > + the PCI controller bridge. > + > + This is here for aiding in debugging issues with the hardware. > + Thanks for your patches. Handling errors sounds good. About this particular one, I'm not so keen on introducing Kconfig options for each driver. Instead I'd prefer to handle this during runtime or as Valentine suggested using CONFIG_PCI_DEBUG. Cheers, / magnus -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
