On Thursday, January 30, 2014 08:56:05 AM Yinghai Lu wrote: > > --047d7b5d2ea4eb937804f132eedf > Content-Type: text/plain; charset=ISO-8859-1 > > >> The latest mainline kernel "hangs" when Thunderbolt devices are > >> hot-unplugged to the system. I can't see any oops but after hot-unplug I'm > >> getting huge amounts of messages like: > >> > >> [ 352.717001] pci 0000:02:00.0: PME# disabled > >> [ 352.717011] pci 0000:02:00.0: PME# disabled > >> [ 352.717021] pci 0000:02:00.0: PME# disabled > >> [ 352.717032] pci 0000:02:00.0: PME# disabled > >> [ 352.717041] pci 0000:02:00.0: PME# disabled > >> [ 352.717051] pci 0000:02:00.0: PME# disabled > >> [ 352.717061] pci 0000:02:00.0: PME# disabled > >> [ 352.717070] pci 0000:02:00.0: PME# disabled > >> [ 352.717083] pci 0000:02:00.0: PME# disabled > >> [ 352.717094] pci 0000:02:00.0: PME# disabled > >> [ 352.717104] pci 0000:02:00.0: PME# disabled > >> [ 352.717113] pci 0000:02:00.0: PME# disabled > >> [ 352.717124] pci 0000:02:00.0: PME# disabled > >> [ 352.717133] pci 0000:02:00.0: PME# disabled > >> [ 352.717143] pci 0000:02:00.0: PME# disabled > >> [ 352.717153] pci 0000:02:00.0: PME# disabled > >> [ 352.717162] pci 0000:02:00.0: PME# disabled > > > > that mean pci_stop_dev() get called again and again ? > > please check if attached patch could help. Well, it looks like what happens is an endless loop in acpiphp_glue.c:disable_slot(). dev_in_slot() returns the first device in the list, so pci_stop_and_remove_bus_device() is called for it, but it doesn't remove the device from bus->devices any more, so dev_in_slot() will return the same device next time and so on forever. > it should prevent possible reattaching driver. If my analysis above is correct, this isn't related to attaching drivers and rather to the way dev_in_slot() is designed. > --- > drivers/pci/remove.c | 1 + > 1 file changed, 1 insertion(+) > > Index: linux-2.6/drivers/pci/remove.c > =================================================================== > --- linux-2.6.orig/drivers/pci/remove.c > +++ linux-2.6/drivers/pci/remove.c > @@ -11,6 +11,7 @@ static void pci_stop_dev(struct pci_dev > pci_proc_detach_device(dev); > pci_remove_sysfs_dev_files(dev); > device_release_driver(&dev->dev); > + dev->match_driver = false; > dev->is_added = 0; > } So the above won't help in my opinion. I wonder, however, if this patch helps instead: https://patchwork.kernel.org/patch/3540701/ I thought it would be 3.15 material, but it very well can go in earlier if it happens to address this particular problem. Mika, can you please try that? -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
