> -----Original Message----- > From: Mohit Kumar [mailto:mohit.kumar@xxxxxx] > Sent: Thursday, January 23, 2014 7:33 PM > Cc: Pratyush Anand; Mohit Kumar; Jingoo Han; Viresh Kumar; spear-devel@xxxxxxxxxxx; linux- > pci@xxxxxxxxxxxxxxx > Subject: [PATCH V2 7/8] pcie: SPEAr13xx: Add designware pcie support > > From: Pratyush Anand <pratyush.anand@xxxxxx> > > SPEAr1310 and SPEAr1340 SOC uses designware PCIe controller. Add > SPEAr13xx PCIe driver based on designware controller driver. > > SPEAr1310 has 3 PCIe ports and SPEAr1340 has 1, which are multiplexed > with ahci/sata pins. By default evaluation board of both controller > works for ahci mode. > To use these patches on SPEAr1340/1310 evaluation board, do the > necessary modifications on board and enable (okay) pcie from respective > evb dtsi file. > > Signed-off-by: Pratyush Anand <pratyush.anand@xxxxxx> > Signed-off-by: Mohit Kumar <mohit.kumar@xxxxxx> > Cc: Mohit Kumar <mohit.kumar@xxxxxx> > Cc: Jingoo Han <jg1.han@xxxxxxxxxxx> > Cc: Viresh Kumar <viresh.linux@xxxxxxxxx> > Cc: spear-devel@xxxxxxxxxxx > Cc: linux-pci@xxxxxxxxxxxxxxx > --- > arch/arm/boot/dts/spear13xx.dtsi | 53 +++++- > arch/arm/configs/spear13xx_defconfig | 2 + > arch/arm/mach-spear/Kconfig | 1 + > drivers/mfd/spear13xx-cfg.c | 205 ++++++++++++++++++ > drivers/pci/host/Kconfig | 5 + > drivers/pci/host/Makefile | 1 + > drivers/pci/host/pcie-spear13xx.c | 394 ++++++++++++++++++++++++++++++++++ (+cc Thierry Reding) How about changing the file name to 'pci-spear13xx.c'? Now, all PCI host drivers are using the prefix 'pci-', not 'pcie-'. According to the Thierry Reding's comment, "I think we should keep these sorted alphabetically. Also Tegra and Marvell are PCIe controllers but they still use the pci- prefix instead of pcie-. Perhaps it'd be good to keep consistency here? I initially chose pci- because from a software point of view it doesn't matter all that much whether it's PCI or PCIe and because the drivers are part of the PCI subsystem. However if Exynos now uses the pcie- prefix it makes it look like Tegra and Marvell are plain old PCI." (https://groups.google.com/forum/#!msg/linux.kernel/qtimJoNSc3w/_1aayHaG54YJ) If there is a special reason, please let us know. Other things look good. :-) Thank you. Best regards, Jingoo Han > 7 files changed, 659 insertions(+), 2 deletions(-) > create mode 100644 drivers/pci/host/pcie-spear13xx.c -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
