On Thu, Jan 23, 2014 at 02:46:31PM -0500, Dave Jones wrote: > On Thu, Jan 23, 2014 at 11:34:05AM -0800, Greg Kroah-Hartman wrote: > > On Thu, Jan 23, 2014 at 11:42:46AM -0700, Bjorn Helgaas wrote: > > > FYI. I think the first two (related to "name") are valid. I haven't > > > figured out the "msi_attrs" one yet. > > > > I've send a fix for the first two to you now, that should resolve this > > issue. > > > > But the last one, I can't figure out either. I think Coverity doesn't > > realize that we saved off the pointer and can get back to it later on, > > as it's a non-trivial pointer chain involved here. > > This is in the error path though, where we're tearing down all that stuff > we just built up, so there is no 'later on' afaict. If we took one of the > error_* branches, we're not storing this for anything to free later. > > I've only looked at this quickly, but it looks valid to me. > > it looks like we're freeing the contents of the array, but not the array itself. Doh, you are right, I missed that, thanks, I'll go send a fix for this. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
