On Thu, Jan 16, 2014 at 03:25:41PM +0800, Mohit KUMAR DCG wrote: > Hi Arnd, > > > > -----Original Message----- > > From: Arnd Bergmann [mailto:arnd@xxxxxxxx] > > Sent: Sunday, December 15, 2013 12:33 AM > > To: Mohit KUMAR DCG > > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; > > Pratyush ANAND; spear-devel; Viresh Kumar > > Subject: Re: [PATCH 02/12] SPEAr13xx: Move SPEAr1340 definitions to > > header file > > > > On Friday 13 December 2013, Mohit KUMAR DCG wrote: > > > > The RST bits should probably go into a drivers/reset driver. Not > > > > sure what the other registers do, but I'm sure we can find a driver > > > > for these too, possibly they should be part of the PHY driver? > > > > > > - Perhaps if we implement phy and reset driver then we may not > > > require to move these definitions and it will address most of your > > > comments on SPEar13xx pcie driver. I am understanding and working on > > > this.l > > > > > Though we are almost ready with v2. But few concerns: > > There are Spear soc common register used for misc configurations of clock, reset etc for all ips. Few of > registers from the same area are also used for pcie/sata muxing and auxiliary clock configurations. > For example: sata_miphy_init in arch/arm/mach-spear/spear1340.c also uses these registers. > > We have moved all these sata specific spear1340 configurations in a separate driver. On the basis of spear-ahci dt > Node this driver's probe is called, which further adds ahci platform driver. > We plan to put all spear1340/1310_pcie_miphy_init/exit functions of patch 9/12 of this series in > The same driver. > > Now our concern is, what could be the best place to keep that driver, phy, reset or any other framework? > Or we keep this new driver in arch/arm/mach-spear only. I think this misc configuration register block resource should be passed to syscon (drivers/mfd/syscon.c) driver. regmap_update_bits should be used to update these registers and hence to configure pcie/sata settings. As far as place is concerned, that can be kept into mfd and can be named as spear13xx-syscon.c Whats your opinion arnd? Regards Pratyush > > Regards > Mohit > > > > > Ok, very good. > > > > Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
