[PATCHv2 0/2] PCI: driver function reset notification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Here's version 2 of this patch with a driver implementing the intended
use as an example.

The NVMe stuff requires using the maintainer's tree to get the newly
added nvme reset handling code. Willy's repo is located here:

git.infradead.org/users/willy/linux-nvme.git

v1->v2:

As suggested, I'm reusing the slot_reset error handler instead of defining
a new one for function_reset.

I moved invoking the callback further up the this call stack. The test
case I use resets the device via sysfs, and the pci device's command
register is cleared at the previous point, so the callback couldn't
actually do anything useful other than schedule something to handle
it after pci_dev_restore is called. The previous location would break
other driver slot_reset implementations and make my nvme implementation
a little more complicated.

Actually ... I'm a little concered to be using slot_reset instead of
defining a new callback for FLR. From looking at other device drivers,
I'm not sure they would expect to have their slot_reset invoked in
this situation.

Keith Busch (2):
  PCI: call pci reset callback to pci_driver on FLR
  NVMe: Implement pci reset callback

 drivers/block/nvme-core.c |   36 ++++++++++++++++++++++++++++++++++--
 drivers/pci/pci.c         |    6 ++++++
 include/linux/nvme.h      |    1 +
 3 files changed, 41 insertions(+), 2 deletions(-)

-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux