On Fri, Jan 10, 2014 at 5:27 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
> From: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>
>
> My philosophy is unused code is dead code. And dead code is subject to bit
> rot and is a likely source of bugs. Use it or lose it.
>
> This reverts part of f46753c5e354 ("PCI: introduce pci_slot") and
> d25b7c8d6ba2 ("PCI: rename pci_update_slot_number to pci_renumber_slot"),
> removing this interface:
>
> pci_renumber_slot()
>
> [bhelgaas: split to separate patch]
> Signed-off-by: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> CC: Alex Chiang <achiang@xxxxxxxxxxxxx>
> ---
> drivers/pci/slot.c | 26 --------------------------
> include/linux/pci.h | 1 -
> 2 files changed, 27 deletions(-)
>
> diff --git a/drivers/pci/slot.c b/drivers/pci/slot.c
> index 448ca562d1f8..7dd62fa9d0bd 100644
> --- a/drivers/pci/slot.c
> +++ b/drivers/pci/slot.c
> @@ -320,32 +320,6 @@ err:
> EXPORT_SYMBOL_GPL(pci_create_slot);
>
> /**
> - * pci_renumber_slot - update %struct pci_slot -> number
> - * @slot: &struct pci_slot to update
> - * @slot_nr: new number for slot
> - *
> - * The primary purpose of this interface is to allow callers who earlier
> - * created a placeholder slot in pci_create_slot() by passing a -1 as
> - * slot_nr, to update their %struct pci_slot with the correct @slot_nr.
> - */
Reference to why this code/interface was originally thought to be needed:
https://lkml.org/lkml/2008/10/9/58
But anyway, if no one is using the interface, then I agree to kill it.
Acked-by: Alex Chiang <achiang@xxxxxxxxxxxxx>
> -void pci_renumber_slot(struct pci_slot *slot, int slot_nr)
> -{
> - struct pci_slot *tmp;
> -
> - down_write(&pci_bus_sem);
> -
> - list_for_each_entry(tmp, &slot->bus->slots, list) {
> - WARN_ON(tmp->number == slot_nr);
> - goto out;
> - }
> -
> - slot->number = slot_nr;
> -out:
> - up_write(&pci_bus_sem);
> -}
> -EXPORT_SYMBOL_GPL(pci_renumber_slot);
> -
> -/**
> * pci_destroy_slot - decrement refcount for physical PCI slot
> * @slot: struct pci_slot to decrement
> *
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 583348275085..9d860912dd88 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -763,7 +763,6 @@ struct pci_slot *pci_create_slot(struct pci_bus *parent, int slot_nr,
> const char *name,
> struct hotplug_slot *hotplug);
> void pci_destroy_slot(struct pci_slot *slot);
> -void pci_renumber_slot(struct pci_slot *slot, int slot_nr);
> int pci_scan_slot(struct pci_bus *bus, int devfn);
> struct pci_dev *pci_scan_single_device(struct pci_bus *bus, int devfn);
> void pci_device_add(struct pci_dev *dev, struct pci_bus *bus);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
