On Monday, January 06, 2014 11:28:43 AM Yinghai Lu wrote: > On Thu, Jan 2, 2014 at 4:45 PM, Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote: > > On Thursday, January 02, 2014 02:47:04 PM Yinghai Lu wrote: > >> > >> No. It should be before removing all root bus devices. > >> as they need to access the pci devices during stop ioapic and dmar. > >> > >> Also ioapic itself could one one pci device. > > > > Well, if we stop drivers first, then stop ioapic/dmar and *then* remove > > devices, it is possible to rebind a driver to a device after ioapic/dmar has > > been stopped, which I guess will not lead to anything nice? > > Not sure how that could happen. > > If it would really happen, we could set dev->match_driver to 0 in pci_stop_dev. Simply, run "modprobe -r driver && modprobe driver" in a loop and remove the PCI host bridge the given device is on in parallel to that. Chances are, you'll see some nice breakage. Also what happens if somebody uses the "remove" sysfs attribute on a device needed by ioapic/dmar? Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
