On Mon, Dec 23, 2013 at 8:13 AM, <Kashyap.Desai@xxxxxxx> wrote: > This patch has fix for LSI Gen-1 MR controller issue which only pop-up on > few systems and it is not generic. > > On few system, MR 1078 MR controller is not working if mmio decoding is off. > This patch proposed early quirck entry for Device id 0x1000/0x0411 to enable mmio. > > Signed-off-by: Kashyap Desai <kashyap.desai@xxxxxxx> > --- > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index f6c31fa..a20fe41 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -43,6 +43,10 @@ static void quirk_mmio_always_on(struct pci_dev *dev) > } > DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_ANY_ID, PCI_ANY_ID, > PCI_CLASS_BRIDGE_HOST, 8, quirk_mmio_always_on); > +/* LSI controller device id 0x0411 has some issues if mmio_always_on is not set. > + * It pop-up only on few specific system, where decoding disable is not working. > + */ > +DECLARE_PCI_FIXUP_EARLY(0x1000, 0x0411, quirk_mmio_always_on); What is the actual problem that happens without this quirk? Is there some hardware defect in the MR 1078 that makes it fail when we disable decoding? Disabling decoding is important because it prevents conflicts with other devices while sizing and updating BARs, so I don't want to use this quirk unless it's really necessary. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
