On Friday, December 13, 2013 1:30 PM, Mohit KUMAR DCG wrote:
> On Thursday, December 12, 2013 4:31 AM, Arnd Bergmann wrote:
> > On Wednesday 11 December 2013, Mohit Kumar wrote:
[.....]
> > > +struct spear13xx_pcie {
> > > + void __iomem *phy_base;
> > > + void __iomem *app_base;
> > > + struct clk *clk;
> > > + struct pcie_port pp;
> > > + int id;
> > > + int is_gen1;
> > > +};
> >
> > The pcie driver shouldn't have direct access to the phy registers, use a phy
> > driver for that.
>
> - OK. In few workarounds we have to access controller as well as phy registers,
> How we should handle such cases if we separate out phy driver from here? Should it be
> through phy global functions called from pcie driver?
Arnd, do you mean the following?
1. Implement Spear PCIe PHY driver using General PHY framework.
./drivers/phy/phy-spear13xx-pcie.c
2. Call General PHY APIs
./drivers/pci/host/pcie-spear13xx.c
#include <linux/phy/phy.h>
pp->phy = devm_phy_get(pp->dev, ...);
phy_power_on(pp->phy);
phy_power_off(pp->phy);
Best regards,
Jingoo Han
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
