Hello Arnd, > -----Original Message----- > From: Jingoo Han [mailto:jg1.han@xxxxxxxxxxx] > Sent: Thursday, December 12, 2013 4:19 AM > To: Mohit KUMAR DCG; 'Arnd Bergmann' > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; 'Jagan Teki'; linux- > pci@xxxxxxxxxxxxxxx; spear-devel; Pratyush ANAND; 'Jingoo Han' > Subject: Re: [PATCH 06/12] pcie: designware: Move register definition to the > header file > > On Thursday, December 12, 2013 6:32 AM, Arnd Bergmann wrote: > > On Wednesday 11 December 2013, Mohit KUMAR DCG wrote: > > > > > > > > Seems like none were using these headers except pcie-designware.c > > > > - if ie the case better to place it same place as before. > > > > > > - We have include these and used few like ' > > > PCIE_LINK_WIDTH_SPEED_CONTROL ' for SPEAr13xx platform, so move > these to the separate header file. > > > > I think it's better not to touch any of the registers from a > > platform-specific driver. Better make a high-level function in the > > common code that the spear driver can call to change this register. > > I also agree with Arnd's opinion. - As suggested, I will implement required functions in dw driver and hence no need to move register definitions. Regards Mohit -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
