On Wednesday, December 11, 2013 7:30 PM, Marek Vasut wrote:
>
> Some boards do not have a PCIe reset GPIO. To avoid probe
> failure on these boards, make the reset GPIO optional as
> well.
>
> Signed-off-by: Marek Vasut <marex@xxxxxxx>
> Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> Cc: Frank Li <lznuaa@xxxxxxxxx>
> Cc: Harro Haan <hrhaan@xxxxxxxxx>
> Cc: Jingoo Han <jg1.han@xxxxxxxxxxx>
> Cc: Mohit KUMAR <Mohit.KUMAR@xxxxxx>
> Cc: Pratyush Anand <pratyush.anand@xxxxxx>
> Cc: Richard Zhu <r65037@xxxxxxxxxxxxx>
> Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> Cc: Sean Cross <xobs@xxxxxxxxxx>
> Cc: Shawn Guo <shawn.guo@xxxxxxxxxx>
> Cc: Siva Reddy Kallam <siva.kallam@xxxxxxxxxxx>
> Cc: Srikanth T Shivanand <ts.srikanth@xxxxxxxxxxx>
> Cc: Tim Harvey <tharvey@xxxxxxxxxxxxx>
> Cc: Troy Kisky <troy.kisky@xxxxxxxxxxxxxxxxxxx>
> Cc: Yinghai Lu <yinghai@xxxxxxxxxx>
> ---
> .../devicetree/bindings/pci/designware-pcie.txt | 2 +-
> drivers/pci/host/pci-imx6.c | 29 +++++++++++-----------
> 2 files changed, 16 insertions(+), 15 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/designware-pcie.txt
> b/Documentation/devicetree/bindings/pci/designware-pcie.txt
> index d5d26d4..b7a2279 100644
> --- a/Documentation/devicetree/bindings/pci/designware-pcie.txt
> +++ b/Documentation/devicetree/bindings/pci/designware-pcie.txt
> @@ -19,9 +19,9 @@ Required properties:
> to define the mapping of the PCIe interface to interrupt
> numbers.
> - num-lanes: number of lanes to use
> -- reset-gpio: gpio pin number of power good signal
>
> Optional properties for fsl,imx6q-pcie
> +- reset-gpio: gpio pin number of power good signal
(+cc Kishon Vijay Abraham I)
As I said earlier,
'reset-gpio' property can be used for 'samsung,exynos5440-pcie'.
Thus, it is not specific for 'fsl,imx6q-pcie'.
Please, modify it as below:
--- a/Documentation/devicetree/bindings/pci/designware-pcie.txt
+++ b/Documentation/devicetree/bindings/pci/designware-pcie.txt
@@ -19,6 +19,8 @@ Required properties:
to define the mapping of the PCIe interface to interrupt
numbers.
- num-lanes: number of lanes to use
+
+Optional properties
- reset-gpio: gpio pin number of power good signal
Optional properties for fsl,imx6q-pcie
Best regards,
Jingoo Han
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
