On Tuesday, December 10, 2013 at 06:54:00 AM, Jingoo Han wrote: > On Tuesday, December 10, 2013 7:38 AM, Bjorn Helgaas wrote: > > On Mon, Dec 02, 2013 at 01:39:35AM -0200, Fabio Estevam wrote: > > > From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> > > > > > > There is no need to use 'goto err' as we can directly return the > > > errors. > > > > > > Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> > > > > Since there's no functional change, I also applied this one to > > pci/host-imx6 for v3.14. I agree that leaving the DABT handler installed > > is a bug and should be fixed by another patch. > > I also agree with Bjorn's opinion. :-) > Fixing the DABT handler problem can be sent as another patch. Hm, actually I suspect we cannot un-install the handler. See arch/arm/mm/fault.c , the hook_fault_code() call is annotated __init , so it disappears after the init sequence finishes. This basically leaves us with disallowing the mx6 pcie driver to be removed from kernel (don't let it compile as a module), which I dont think is much of a problem anyway. Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
