On Sun, 2013-12-08 at 16:12 +0100, Borislav Petkov wrote:
> From: Borislav Petkov <bp@xxxxxxx>
>
> ... and call it instead of duplicating the large printk format
> statement.
>
> No functionality change.
You do change the output.
Perhaps it'd be better to pass the header prefix too.
> diff --git a/drivers/pci/pcie/aer/aerdrv_errprint.c b/drivers/pci/pcie/aer/aerdrv_errprint.c
[]
> @@ -124,6 +124,21 @@ static const char *aer_agent_string[] = {
> +static void __print_tlp_header(struct pci_dev *dev,
> + struct aer_header_log_regs *t)
> +{
> + unsigned char *tlp = (unsigned char *)&t;
> +
> + dev_err(&dev->dev, " TLP Header:"
Always indents and emits " TLP Header:"
> @@ -250,18 +256,10 @@ void cper_print_aer(struct pci_dev *dev, int cper_severity,
> if (aer_severity != AER_CORRECTABLE)
> dev_err(&dev->dev, "aer_uncor_severity: 0x%08x\n",
> aer->uncor_severity);
> - if (tlp_header_valid) {
> - const unsigned char *tlp;
> - tlp = (const unsigned char *)&aer->header_log;
> - dev_err(&dev->dev, "aer_tlp_header:"
vs removing this "aer_tlp_header:"
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
