[+to BenH]
On Sat, Dec 7, 2013 at 2:23 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
> [+cc Yinghai]
>
> On Wed, Oct 9, 2013 at 8:33 AM, Jean Delvare <jdelvare@xxxxxxx> wrote:
>> Since kernel 3.12-rc3, I get the following warning messages at boot:
>> pcieport 0000:00:07.0: driver skip pci_set_master, fix it!
>> pcieport 0000:00:01.0: driver skip pci_set_master, fix it!
>
> cf3e1feba7f9 ("PCI: Workaround missing pci_set_master in pci drivers")
> added this warning and, at the same time, turned on bus mastering.
>
> There didn't seem to be any reason for the warning and no reason why
> bus mastering should be enabled in the driver rather than the core, so
> fbeeb822f6f4 ("PCI: Drop warning about drivers that don't use
> pci_set_master()") just dropped the warning.
>
> This should resolve the problem, so I don't think there's a need for
> this patch. Let me know if otherwise.
BenH mentioned that get_port_device_capability have some problem on powerpc
and will return null.
>>
>> drivers/pci/pcie/portdrv_core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- linux-3.12-rc4.orig/drivers/pci/pcie/portdrv_core.c 2013-09-24 00:41:09.000000000 +0200
>> +++ linux-3.12-rc4/drivers/pci/pcie/portdrv_core.c 2013-10-09 15:43:54.205943783 +0200
>> @@ -366,13 +366,13 @@ int pcie_port_device_register(struct pci
>> status = pci_enable_device(dev);
>> if (status)
>> return status;
>> + pci_set_master(dev);
>>
>> /* Get and check PCI Express port services */
>> capabilities = get_port_device_capability(dev);
>> if (!capabilities)
>> return 0;
>>
>> - pci_set_master(dev);
>> /*
>> * Initialize service irqs. Don't use service devices that
>> * require interrupts if there is no way to generate them.
>>
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
