On Fri, Nov 29, 2013 at 10:53 AM, Greg KH <greg@xxxxxxxxx> wrote: > On Fri, Nov 29, 2013 at 10:41:37AM +0100, Veaceslav Falico wrote: >> On Wed, Nov 27, 2013 at 10:46:52AM -0800, Greg Kroah-Hartman wrote: >> >From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >> > >> >The PCI MSI sysfs code is a mess with kobjects for things that don't >> >really need to be kobjects. This patch creates attributes dynamically >> >for the MSI interrupts instead of using kobjects. >> > >> >Note, this removes a directory from the current MSI interrupt sysfs >> >code: >> > >> >old MSI kobjects: >> >pci_device >> > └── msi_irqs >> > └── 40 >> > └── mode >> > >> >new MSI attributes: >> >pci_device >> > └── msi_irqs >> > └── 40 >> > >> >As there was only one file "mode" with the kobject model, the interrupt >> >number is now a file that returns the "mode" of the interrupt (msi vs. >> >msix). >> > >> >Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >> >> Works like a charm for me. >> >> FWIW, >> >> Reviewed-by: Veaceslav Falico <vfalico@xxxxxxxxxx> > > On Thu, Nov 28, 2013 at 10:14:19PM -0500, Neil Horman wrote: >> ACK, Testing with git-head irqbalance on F19 with this patch and it works fine. >> >> Thanks! >> Acked-by: Neil Horman <nhorman@xxxxxxxxxxxxx> > > Great, thanks for both of you testing this. > > Bjorn, any objection to take this through your tree for 3.14-rc1? Nope, I don't object at all. We probably should update Documentation/ABI/testing/sysfs-bus-pci at the same time, though. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
