Dear Fabio Estevam, > From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> > > There is no need to use 'goto err' as we can directly return the errors. > > Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> I am a bit worried about unwinding of the installation of the DABT hook: 424 /* Added for PCI abort handling */ 425 hook_fault_code(16 + 6, imx6q_pcie_abort_handler, SIGBUS, 0, 426 "imprecise external abort"); This is not handled in the fail path. Instead of this patch, would it be possible for you to fix the failpath to take this part into consideration? Another option, and I think even a better one, would be to move this DABT handler installation just before imx6_add_pcie_port() call. You'd still need to handle it's de-installation in remove(), but you won't have so many functions in probe() goto-ing to fail path. Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
