On Mon, Nov 25, 2013 at 10:53 PM, Rajat Jain <rajatjain@xxxxxxxxxxx> wrote: > Bjorn: Actually this threads brings up an good point. Is "DLL State changed" bit in "Slot Status" ALWAYS updated without regard to whether the Link state notifications were enabled or not? That's the way I read it. I assume you're referring to the "DLL State Changed Enable" bit in Slot Control. I don't see anything in the spec about "DLL State Changed" depending on that. > Looks like it. If yes, I'll take this as an input to make a 1 line change to my patch: > > Currently in my patch, the pciehp_use_link_events=1 is used to only enable link state change notifications, but in case pcie_isr() finds "DLL changed" bit set in "Slot status", it processes the link state change. I'll make the single line change to pcie_isr() to process the event only if pciehp_use_link_events=1. Let me know if this sounds alright. If we can avoid it, I'd prefer not to add the "pciehp_use_link_events" module parameter. What would break if we just *always* used link events? Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
