On Tue, Nov 26, 2013 at 02:31:44PM +0900, Jingoo Han wrote: > > On Tuesday, November 26, 2013 5:03 AM, Jason Gunthorpe wrote: > > On Sat, Nov 23, 2013 at 10:00:33PM -0500, Jason Cooper wrote: > > > And a small addendum: I currently have the following in mvebu/drivers > > > 058100a08be8 PCI: mvebu: return NULL instead of ERR_PTR(ret) > > > > Folks, I took a quick look at this, and it looks suspicious (sorry, I > > can't seem to find the thread to followup post) > > > > > PCI: mvebu: return NULL instead of ERR_PTR(ret) > > > > > > Return NULL instead of ERR_PTR(ret) in order to fix the following > > > sparse warning: > > > > > > drivers/pci/host/pci-mvebu.c:744:31: warning: incorrect type in return expression (different > > address > > > spaces) > > > drivers/pci/host/pci-mvebu.c:744:31: expected void [noderef] <asn:2>* > > > drivers/pci/host/pci-mvebu.c:744:31: got void * > > > > > > Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx> > > > Acked-by: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx> > > > Signed-off-by: Jason Cooper <jason@xxxxxxxxxxxxxx> > > > > > >--- a/drivers/pci/host/pci-mvebu.c > > >+++ b/drivers/pci/host/pci-mvebu.c > > >@@ -740,7 +740,7 @@ static void __iomem *mvebu_pcie_map_registers(struct platform_device *pdev, > > > > > > ret = of_address_to_resource(np, 0, ®s); > > > if (ret) > > >- return ERR_PTR(ret); > > >+ return NULL; > > > > > > return devm_ioremap_resource(&pdev->dev, ®s); > > > > So we drop the ERR_PTR for that return but 'devm_ioremap_resource' > > returns ERR_PTR too: > > Yes, you're right. > It makes the problem. > Thus, this commit "PCI: mvebu: return NULL instead of ERR_PTR(ret)" > should be reverted. It hasn't gone to mainline yet and I haven't sent a pull request for it yet. So I can just drop it. Since we have the discussion on all three of those patches re-ignited, I'll just drop the branch and Ack the resends for going through Bjorn. thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
