On 11/12/2013 09:14 PM, Bjorn Helgaas wrote: > On Tue, Nov 12, 2013 at 11:25 AM, Grumbach, Emmanuel > <emmanuel.grumbach@xxxxxxxxx> wrote: > >> Right - I remember the discussion we had on that. >> On this device (7260 that has an issue with ASPM), we don't call pci_disable_link_state, because we know it is supposed to work... > > If ASPM is supposed to work as far as the hardware is concerned, I > guess you're saying this must be an iwlwifi driver issue. Right? ASPM is supposed to work as far as the hardware is concerned. We might very well have an issue in iwlwifi - and I am checking this internally with our System guys. It can be a PCI core problem too, and it could also be a platform / BIOS / Lenovo issue. Of course, I have no clue which of these is the culprit here. Our System folks seemed to say that this new device uses L1 substates which can be enabled in Haswell platform which the user owns. Now - L1 substates is a new feature and might introduce issues (apparently) - and this is why they (System folks) wanted the try without L1 substates. But disabling L1 substates doesn't seem trivial with the production BIOS of Lenovo. So I am pretty stuck here. Another possibility is to run a PCI analyser on the machine, but that requires to have the machine in the lab... > If you think it's a PCI core problem, we have to figure out what the > core needs to do differently. If somebody can point to a difference > in the ASPM configuration between Windows and Linux, that would be a > good start. > > Bjorn > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
