Hello, >> With my patch, we'd eliminate the 1 second delay and the second line >> of output above. If we also want to get rid of the first line >> "Unexpected CMD_COMPLETED..." also, that would probably have to be >> solved by changing the behavior to assume that CC shall be generated >> for every SLOTCTRL register write. > > I *do* want to get rid of the "Unexpected CMD_COMPLETED" complaint. > We shouldn't complain about hardware that is working perfectly fine. > I don't know the best way to do that yet. I have found a box with the > same hardware that was fixed by 5808639bfa98, so I hope to play with > it and figure out something that will work nicely for both scenarios. Please keep posted :-) > > BTW, can you open a report at bugzilla.kernel.org and attach your > "lspci -vvxxx" and dmesg output? When we eventually merge a fix, I'd > like to have the details archived somewhere. Done: https://bugzilla.kernel.org/show_bug.cgi?id=64821 Please let me know if you need any help in trying something out - I'd be more than keen to help - write code or test. BTW, I figured another way that solves the current problem at hand (for both kind of controllers). Today the events are cleared just before call to pcie_disable_notification, if we clear them afterwards also, the current problem is taken care of for all controllers. Of course this does not look the right way to solve the problem though (since the ctrl->no_cmd_completed shall still be 1, which is not right). @@ -948,6 +948,10 @@ struct controller *pcie_init(struct pcie_device *dev) /* Clear all remaining event bits in Slot Status register */ if (pciehp_writew(ctrl, PCI_EXP_SLTSTA, 0x1f)) goto abort_ctrl; /* Disable sotfware notification */ pcie_disable_notification(ctrl); + /* Clear all remaining event bits in Slot Status register */ + if (pciehp_writew(ctrl, PCI_EXP_SLTSTA, 0x1f)) + goto abort_ctrl; + ctrl_info(ctrl, "HPC vendor_id %x device_id %x ss_vid %x ss_did %x\n", pdev->vendor, pdev->device, pdev->subsystem_vendor, pdev->subsystem_device); Thanks, Rajat -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
