On Wed, Oct 30, 2013 at 12:57 AM, Yijing Wang <wangyijing@xxxxxxxxxx> wrote: >>>> Bisection points to 928bea964827d7824b548c1f8e06eccbbc4d0d7d . >>> >>> This is "PCI: Delay enabling bridges until they're needed" by Yinghai. >> >> that double disabling should be addressed by: >> >> https://lkml.org/lkml/2013/4/25/608 >> >> [PATCH] PCI: Remove duplicate pci_disable_device for pcie port > > Hi Yinghai and Bjorn, > I found a related issue in the latest Bjorn/pci-next branch. > > Now if we remove the pcie port device in the system, there is a warning occured. > It seems introduced after commit 928bea9 "PCI: Delay enabling bridges until they're needed". > > [ 2124.129478] ------------[ cut here ]------------ > [ 2124.129490] WARNING: CPU: 3 PID: 7 at drivers/pci/pci.c:1424 pci_disable_device+0x90/0xa0() > [ 2124.129492] Device pcieport > [ 2124.129492] disabling already-disabled device yes. that is pcie port driver problem. | 928bea delay bridge enabling, and it's pci_is_enabled checking will prevent | pci bridge get enabled second time, so enable_cnt will be only 1. instead of | 2. if we enable bridge at first and then pcie port driver. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
