On Wed, Oct 9, 2013 at 4:14 AM, Lian Minghuan-b31939 <B31939@xxxxxxxxxxxxx> wrote: > arch/powerpc/sysdev/fsl_pci.c | 521 +----------------- > arch/powerpc/sysdev/fsl_pci.h | 89 ---- > .../fsl_pci.c => drivers/pci/host/pci-fsl-common.c | 591 > +-------------------- > .../fsl_pci.h => include/linux/fsl/pci-common.h | 45 +- > > Is there any way to avoid putting this file in include/linux? I know > you want to share it beyond PowerPC, and I know there are similar > examples there already, but this is all arch-specific or > chipset-specific stuff that seems like it should be in some > not-so-public place. It doesn't seem scalable to add an include/linux > subdirectory for every chipset that might be shared across > architectures. > > [Minghuan] I can move pci-common.h to drivers/pci/host/ > But in arch/powerpc/sysdev/fsl_pci.c I must include the header file > like this: > #include "../../../drivers/pci/host/pci-fsl-common.h". > How about this modification? Given the existence of include/linux/fsl/ even before this patch, I'm OK with it as-is. After you work through Scott's comments on [2/2] and get his ack, I'll merge the whole bundle as a group. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
