On Wednesday, October 09, 2013 6:06 PM, Kishon Vijay Abraham I wrote: > On Wednesday 09 October 2013 01:39 PM, Jingoo Han wrote: > > Without irq_create_mapping(), the correct irq number cannot be > > provided. In this case, it makes problem such as NULL deference. > > Thus, irq_create_mapping() should be added for MSI. > > > > Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx> > > Cc: Kishon Vijay Abraham I <kishon@xxxxxx> > > --- > > Tested on Exynos5440. > > > > drivers/pci/host/pcie-designware.c | 10 ++++------ > > drivers/pci/host/pcie-designware.h | 1 + > > 2 files changed, 5 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c > > index 8963017..e536bb6 100644 > > --- a/drivers/pci/host/pcie-designware.c > > +++ b/drivers/pci/host/pcie-designware.c > > @@ -237,6 +237,8 @@ static int assign_irq(int no_irqs, struct msi_desc *desc, int *pos) > > } > > } > > > > + pp->msi_irq_start = irq_create_mapping(pp->irq_domain, 0); > > + > > I think irq_create_mapping should be done for all the MSI irq lines instead of > only the first line. So you might have to do for MAX_MSI_IRQS lines. I tested PCIe LAN card after I replaced 0 with MAX_MSI_IRQS. However, it makes an error message as below: But, PCIe LAN card works properly. WARNING: CPU: 1 PID: 1 at kernel/irq/irqdomain.c:276 irq_domain_associate+0x150/0x1a8() error: hwirq 0x20 is too large for (null) Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
