On Mon, Oct 7, 2013 at 6:04 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: > The following variables and functions are used only in pcie-designware.c, > so make them static: ... > diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c > index c10e9ac..900e875 100644 > --- a/drivers/pci/host/pcie-designware.c > +++ b/drivers/pci/host/pcie-designware.c > @@ -64,7 +64,7 @@ > > static struct hw_pci dw_pci; > > -unsigned long global_io_offset; > +static unsigned long global_io_offset; While you're looking at this, I think "cfg_read()" and "cfg_write()" are too generic to be global symbols. I don't know if it would make sense to rename them "dw_cfg_read()", pass around pointers in a structure or what. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
