[Resend to the mailing list due to the bounceback caused by html format]
On 10/04/2013 09:37 PM, Bjorn Helgaas wrote:
On Fri, Oct 4, 2013 at 9:42 PM, DengCheng Zhu <DengCheng.Zhu@xxxxxxxxxx> wrote:
Does this fix a user-visible problem? If so, what does it look like
when the problem occurs?
No, I found the problem while debugging another issue and trying to
understand this piece of code and after looking into different versions of
PIIX4 datasheets. But I don't think it should prevent such a fix because
the code is straightforward and the spec is clear enough. If the existing
encoding was intentionally made like this by the code author due to the
inaccuracy of the spec, then it's very likely some code comments were
placed here. There are 2 possibilities:
- This fix breaks something. People should have to bisect the problem.
- This fix is valid. Some day people need PIIX4 mem quirks and they don't
have to run into a possibly well-hidden issue.
What do you think?
Don't worry, I'm willing to fix it even if nobody has actually
reported a problem. It's just nice to include the symptoms if
somebody *has* reported it, so when other people see the same symptom,
they can more easily find the fix.
Ah, I see. Thanks.
So far I didn't see them on any branch in kernel/git/helgaas/pci.git
<https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/>
Is this the right place to look at? Thanks.
Deng-Cheng
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
