Re: [PATCH] iommu: Remove stack trace from broken irq remapping warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 03, 2013 at 10:08:24PM +0200, Joerg Roedel wrote:
> On Thu, Oct 03, 2013 at 01:21:42PM -0400, Neil Horman wrote:
> > On Fri, Sep 27, 2013 at 12:53:35PM -0400, Neil Horman wrote:
> > > The warning for the irq remapping broken check in intel_irq_remapping.c is
> > > pretty pointless.  We need the warning, but we know where its comming from, the
> > > stack trace will always be the same, and it needlessly triggers things like
> > > Abrt.  This changes the warning to just print a text warning about BIOS being
> > > broken, without the stack trace, then sets the appropriate taint bit.  Since we
> > > automatically disable irq remapping, theres no need to contiue making Abrt jump
> > > at this problem
> > > 
> > > Signed-off-by: Neil Horman <nhorman@xxxxxxxxxxxxx>
> > > CC: Joerg Roedel <joro@xxxxxxxxxx>
> > > CC: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> > > CC: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
> > > CC: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> > > CC: Sebastian Andrzej Siewior <sebastian@xxxxxxxxxxxxx>
> > 
> > Ping Bjorn, Jeorg, any thoughts here?
> 
> Yes, the patch is doing the right thing. I have it already on my list
> and will merge it soon.
> 
Awesome, thanks guys.  Regarding the taint, I'll propose something for that
early next week.

Regards
Neil

> 
> 	Joerg
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux