On Wed, Sep 25, 2013 at 7:37 AM, Lan Tianyu <tianyu.lan@xxxxxxxxx> wrote: > On 09/25/2013 08:19 AM, Bjorn Helgaas wrote: >> >> On Mon, Sep 09, 2013 at 11:17:15PM -0400, tianyu.lan@xxxxxxxxx wrote: >>> >>> From: Lan Tianyu <tianyu.lan@xxxxxxxxx> >>> >>> This patch is to use pr_debug/info/warn/err to replace acpiphp debug >>> functions and remove module's debug param. >>> ... >> >> >>> /* local variables */ >>> @@ -61,9 +60,7 @@ static struct acpiphp_attention_info *attention_info; >>> MODULE_AUTHOR(DRIVER_AUTHOR); >>> MODULE_DESCRIPTION(DRIVER_DESC); >>> MODULE_LICENSE("GPL"); >>> -MODULE_PARM_DESC(debug, "Debugging mode enabled or not"); >>> MODULE_PARM_DESC(disable, "disable acpiphp driver"); >>> -module_param_named(debug, acpiphp_debug, bool, 0644); >> >> >> I have notes about booting with the "acpiphp.debug" parameter to turn >> on debugging. Can you tell me the way to do the equivalent with >> dynamic debug? I'll add that to the changelog before merging this. > > Hi Bjorn: > Sure, the counterparts of dynamic debug are "acpiphp.dyndbg=+p" and > "acpiphp_ibm.dyndbg=+p" parameters. Thanks to add them. And turn on CONFIG_DYNAMIC_DEBUG. I updated the changelogs and applied both patches to my pci/misc branch for v3.13. Thanks! Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html