On Tue, Sep 17, 2013 at 09:05:20PM +0200, Thomas Petazzoni wrote: > Dear Jason Gunthorpe, > > On Tue, 17 Sep 2013 12:32:50 -0600, Jason Gunthorpe wrote: > > Otherwise hotplugging the PEX doesn't work at all since the driver > > detects the link state at probe time. Simply replacing the two tests > > of haslink with a register read is enough to fix discovery. > > > > Signed-off-by: Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx> > > I don't have the hardware to test, but this seems to make sense to me. FWIW, I have tested this on Kirkwood: mvebu-pcie pex.1: PCI host bridge to bus 0000:00 pci_bus 0000:00: root bus resource [mem 0xe0000000-0xf0000000] pci_bus 0000:00: root bus resource [bus 00-ff] pci_bus 0000:00: root bus resource [io 0x1000-0xffff] pci 0000:00:01.0: [11ab:7846] type 01 class 0x060400 PCI: bus0: Fast back to back transfers disabled pci 0000:00:01.0: bridge configuration invalid ([bus 00-00]), reconfiguring PCI: bus1: Fast back to back transfers enabled pci_bus 0000:01: busn_res: [bus 01-ff] end is updated to 01 pci 0000:00:01.0: PCI bridge to [bus 01] [..] Freeing unused kernel memory: 1096K (c02ee000 - c0400000) .. hot plug the device .. echo 1 > rescan pci 0000:01:00.0: [170c:0001] type 00 class 0x058000 pci 0000:01:00.0: reg 0x10: [mem 0x00000000-0x0001ffff] pci 0000:01:00.0: PME# supported from D0 D1 D2 D3hot pci_bus 0000:01: busn_res: [bus 01] end is updated to 01 pci 0000:00:01.0: BAR 8: assigned [mem 0xe0000000-0xe00fffff] pci 0000:01:00.0: BAR 0: assigned [mem 0xe0000000-0xe001ffff] pci 0000:00:01.0: PCI bridge to [bus 01] pci 0000:00:01.0: bridge window [mem 0xe0000000-0xe00fffff] PCI: enabling device 0000:00:01.0 (0140 -> 0143) PCI: enabling device 0000:01:00.0 (0000 -> 0002) Jason -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
