Dear Jingoo Han, On Thu, 12 Sep 2013 18:37:18 +0900, Jingoo Han wrote: > ret = of_address_to_resource(np, 0, ®s); > if (ret) > - return ERR_PTR(ret); > + return (void __iomem *)ERR_PTR(ret); This doesn't look very pretty to tell the truth, but I don't quite see any other option. Just return NULL when of_address_to_resource() fails instead of trying to propagate the error? Make this entire function return an 'int' and have the iomem address returned through a pointer passed by address as argument to the function? Any other suggestion? Thanks, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
